Add [pyoxidizer].lockfile
#16537
Merged
Add [pyoxidizer].lockfile
#16537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
|
100% oversight, I didn't even know about the lockfiles until I made the clang-format plugin. |
sureshjoshi
approved these changes
Aug 16, 2022
|
@Eric-Arellano I asked @chrisjrn about this in Slack, but might this also be a good time to bump the pyox version? It's about 3-4 minor versions old right now. Only reason it's on 0.18 was because that what was out when I wrote this. |
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Sounds good to me. Probably better as a dedicated PR -- technically it's a User API Change. |
thejcannon
approved these changes
Aug 16, 2022
cczona
pushed a commit
to cczona/pants
that referenced
this pull request
Sep 1, 2022
I think that this was missing only due to oversight. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that this was missing only due to oversight.
[ci skip-rust]
[ci skip-build-wheels]