wait for killed nailgun processes. (Cherry-pick of #16924)
#16939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a nailgun process run is cancelled, the `BorrowedNailgunProcess` `Drop` guard is supposed to kill the process, so that the next request to the pool will start a new process. But because we weren't `wait`ing for the process to have actually exited after receiving `SIGKILL`, there was a race condition where we would have sent the signal, but the process had not yet actually exited by the time the next request came along. To fix that, we introduce a `wait`. Eventually, we would like this to use async-`Drop` instead. Fixes pantsbuild#16895. [ci skip-build-wheels]
tdyas
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a nailgun process run is cancelled, the
BorrowedNailgunProcessDropguard is supposed to kill the process, so that the next request to the pool will start a new process.But because we weren't
waiting for the process to have actually exited after receivingSIGKILL, there was a race condition where we would have sent the signal, but the process had not yet actually exited by the time the next request came along.To fix that, we introduce a
wait. Eventually, we would like this to use async-Dropinstead.Fixes #16895.