add basic counters to docker command runner #16989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping |
| @@ -51,6 +51,9 @@ pub enum Metric { | |||
| RemoteStoreMissingDigest, | |||
| /// Number of times that we backtracked due to missing digests. | |||
| BacktrackAttempts, | |||
| DockerExecutionRequests, | |||
| DockerExecutionSuccess, | |||
There was a problem hiding this comment.
We call this Successes for RemoteCacheWrite, but singular for RemoteExecution. I think probably plural is better as we use plural generally
added 2 commits
September 26, 2022 20:05
[ci skip-build-wheels]
[ci skip-build-wheels]
tdyas
force-pushed
the
docker_executor_stats
branch
from
eba9c68 to
3bb31ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add counters to the Docker command runner to count the number of requests with break-down of successes and failures.
[ci skip-build-wheels]