Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/cgo: support compiling C, C++, ObjC, and Fortran sources #17001

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Sep 26, 2022

Thread through the analysis of C, C++, Obj-C, and Fortran sources from the analysis rules through to the compilation rules. This allows building a cgo package with .c files in my testing.

Tom Dyas added 2 commits September 26, 2022 01:26
[ci skip-rust]

[ci skip-build-wheels]
[ci skip-rust]

[ci skip-build-wheels]
@tdyas tdyas added backend: Go Go backend-related issues category:internal CI, fixes for not-yet-released features, etc. labels Sep 26, 2022
Copy link
Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty amazing how little plumbing this required.

@tdyas
Copy link
Contributor Author

tdyas commented Sep 26, 2022

Pretty amazing how little plumbing this required.

Most of the plumbing (i.e., the actual compiler invocations) landed with the original cgo PR. I hadn't hooked any of it though, hence this PR which probably should have been part of that original PR.

@tdyas tdyas merged commit 073dd26 into pantsbuild:main Sep 26, 2022
@tdyas tdyas deleted the golang_cgo_more_work branch September 26, 2022 15:53
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super exciting. Thanks Tom :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: Go Go backend-related issues category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants