Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase delays on remote cache tests #17012

Merged
merged 1 commit into from
Sep 27, 2022
Merged

increase delays on remote cache tests #17012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/rust/engine/process_execution/src/remote_cache_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,17 +367,17 @@ async fn cache_read_speculation() {
assert_eq!(local_call_count, 1);

// Case 4: remote is faster than speculation read delay.
let (exit_code, local_call_count) = run_process(0, 100, 200, true, &mut workunit).await;
let (exit_code, local_call_count) = run_process(0, 0, 200, true, &mut workunit).await;
assert_eq!(exit_code, 0);
assert_eq!(local_call_count, 0);

// Case 5: remote is faster than speculation read delay, but there is no cache entry so we fallback to local execution.
let (exit_code, local_call_count) = run_process(0, 100, 200, false, &mut workunit).await;
let (exit_code, local_call_count) = run_process(0, 0, 200, false, &mut workunit).await;
assert_eq!(exit_code, 1);
assert_eq!(local_call_count, 1);

// Case 6: local with speculation read delay is faster than remote.
let (exit_code, local_call_count) = run_process(0, 200, 100, true, &mut workunit).await;
let (exit_code, local_call_count) = run_process(0, 200, 0, true, &mut workunit).await;
assert_eq!(exit_code, 1);
assert_eq!(local_call_count, 1);
}
Expand Down