Add --docker-execution option
#17049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
added
the
category:internal
tdyas
approved these changes
Sep 28, 2022
stuhood
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
Thanks!
Note that this intentionally is not a bootstrap option. The benefit of it being a bootstrap option is we would avoid creating the Docker command runner when not necessary. But because the Docker command runner is safe to create and lazily connects to Docker, that is fine. By avoiding a bootstrap option, we avoid needing to restart Pantsd, which is desirable.
To be clear: in global_options.py, only daemon=True options trigger "restarts" of pantsd. Options which are fingerprint=True (the default: disabled via fingerprint=False for some options) will trigger a scheduler re-initialization without restarting.
Co-authored-by: Stu Hood <stuhood@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives more flexibility to likely user stories, such as wanting to use Docker in CI but not locally, or vice versa.
Before, the sole way to turn off Docker was on Linux that you used a different platform for the Docker image than the local host. That condition is not possible on macOS, so there was no way to disable Docker there.
[ci skip-rust]
[ci skip-build-wheels]