Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: refactor tailor rule into rule helpers #17082

Merged
merged 3 commits into from
Oct 2, 2022

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Oct 1, 2022

Refactor the tailor rule for Go into several rule helpers.

[ci skip-build-wheels]

[ci skip-rust]

[ci skip-build-wheels]

[ci skip-rust]
@tdyas tdyas added backend: Go Go backend-related issues category:internal CI, fixes for not-yet-released features, etc. labels Oct 1, 2022
@tdyas tdyas requested review from benjyw and Eric-Arellano October 1, 2022 05:33
Tom Dyas added 2 commits October 1, 2022 10:30
[ci skip-rust]

[ci skip-build-wheels]
[ci skip-rust]

[ci skip-build-wheels]
@tdyas tdyas merged commit fb64383 into pantsbuild:main Oct 2, 2022
@tdyas tdyas deleted the golang_tailor_refactor branch October 2, 2022 15:33
@@ -147,10 +147,12 @@ class GoModTarget(TargetGenerator):


class GoPackageSourcesField(MultipleSourcesField):
default = ("*.go", "*.s")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: Go Go backend-related issues category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants