Change fmt/lint/check docs with latest changes #17133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
|
(Still need to do |
|
Docs need to be refreshed when #17192 is in |
Should this be in Draft? |
|
#17192 is in now. I just need to update this (I can't request changes on my own PR, which is what I would've done). Still pretty reviewable IMO. |
stuhood
approved these changes
Oct 18, 2022
|
|
||
| (Why are targetless formatters something we want to support? This allows us to have `BUILD` file formatters, | ||
| formatters like `Prettier` running on your codebase *without* boilerplate targets, as well as Pants | ||
| doing interesting deprecation fixers on its own files) |
There was a problem hiding this comment.
Suggested change
| doing interesting deprecation fixers on its own files) | |
| doing interesting deprecation fixers on its own files.) |
|
|
||
| ----- | ||
|
|
||
| As always, taking a look at Pants' own plugins can also be very enlightening. |
There was a problem hiding this comment.
A permalink to one would be great.
|
oh shoot. got trigger happy and merged. I'll bring these two comments into the inevitable next change of the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the docs to keep the "lowest-bar-to-entry" example but compatible with the new changes. I don't love it, but I'm also not feeling very creative.
Fixes #16865
[ci skip-rust]
[ci skip-build-wheels]