Migrates generate-lockfiles to USES_ENVIRONMENTS.
#17300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 20, 2022 10:24
(cherry picked from commit b8045313375093894515ca24becd0ed17aaa4f02)
…ocal environment in all cases.
…to specify execution environments
This reverts commit c25b1ec.
…te-lockfiles-attempt-2
stuhood
reviewed
Oct 20, 2022
| @@ -407,6 +430,25 @@ async def generate_lockfiles_goal( | |||
| return GenerateLockfilesGoal(exit_code=0) | |||
|
|
|||
|
|
|||
| def _preferred_environment(request: GenerateLockfile, default: EnvironmentName) -> EnvironmentName: | |||
|
|
|||
| if not isinstance(request, GenerateLockfileWithEnvironments): | |||
There was a problem hiding this comment.
An alternative to subtyping might be to give GenerateLockfile a field which is optional (for now?)
environments: tuple[EnvironmentName, ...] | None = NoneThere was a problem hiding this comment.
Alas, it's not possible to have an optional value there, because GenerateLockfile has subclasses with required parameters. dataclasses doesn't make this case easy.
Co-authored-by: Stu Hood <stuhood@gmail.com>
chrisjrn
added
the
category:internal
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a least-effort attempt at getting
generate-lockfilesinto a position where individual backend implementations can select an environment in which to generate the lockfiles.The request generation phase runs in the default local environment, and is responsible for adding an
environmentsfield to theGenerateLockfilerequest object.If a request does not specify environments, the
GenerateLockfilerequest is run in the default local environment. If a single environment is specified, that environment is to run the request. If more than one environment is specified, a warning is displayed, and the request runs in either the default local environment (if present in the request), or an arbitrary environment.This approach will give us an avenue in the future to run the request in all the specified environments, and add behaviour to somehow merge the resulting lockfiles if different, since the eventual act of writing the lockfiles to disk happens in the rule goal code.
Addresses #17129