Updates publish to USES_ENVIRONMENTS
#17313
Conversation
chrisjrn
force-pushed
the
chrisjrn/17129-publish
branch
from
b2c1488 to
3e8587e
Compare
chrisjrn
added
the
category:internal
| res = await Effect( | ||
| InteractiveProcessResult, | ||
| {pub.process: InteractiveProcess, local_environment.val: EnvironmentName}, | ||
| ) |
There was a problem hiding this comment.
It's likely that some publish implementations will need to pin the construction of the actual publish command to use back to the local environment... because otherwise they might consume environment variables / etc to construct it "for" a remote environment?
i.e.: Do packaging/etc in some environment, but then construct a publish command for the local environment.
I'm not sure if that suggests that they should each need to figure out their own environment internally instead... but ... maybe?
There was a problem hiding this comment.
Isn't that what's going on here? The packaging request is using the environment that's needed to successfully construct the package, but the publish command is run locally.
| packages = await MultiGet( | ||
| Get(BuiltPackage, PackageFieldSet, field_set) for field_set in request.package_field_sets | ||
| Get(BuiltPackage, EnvironmentAwarePackageRequest(field_set)) | ||
| for field_set in request.package_field_sets |
There was a problem hiding this comment.
@stuhood this is where the package operation is potentially performed in a different environment.
| { | ||
| field_set._request(packages): PublishRequest, | ||
| local_environment.val: EnvironmentName, | ||
| }, |
There was a problem hiding this comment.
@stuhood This is where the publish processes are constructed, pinned to the local environment.
There was a problem hiding this comment.
Yea, you're right! I forgot that PublishProcesses doesn't actually do any of the building, and that that happens via BuiltPackage.
| { | ||
| field_set._request(packages): PublishRequest, | ||
| local_environment.val: EnvironmentName, | ||
| }, |
There was a problem hiding this comment.
Yea, you're right! I forgot that PublishProcesses doesn't actually do any of the building, and that that happens via BuiltPackage.
This migrates
publishto create theBuiltPackageasset in a correct environment, and run thepublishexecutable in the local environment.Also adds a helper rule,
EnvironmentAwarePackageRequest, which consolidates theEnvironmentNamerequest andBuiltPackagerequest, sinceBuiltPackageis requested all over the place.See #17129.