Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds warning if lint/fmt/fix runs on a target using a non-local environment. #17359

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

chrisjrn
Copy link
Contributor

This adds a warning if a target-based fmt/lint/fix operation runs against a target that specifies a non-local environment.

To property use environments, we'll need a way of making the partitioning rules a bit more pluggable, or decide that individual back-end implementations will be responsible for deciding where they run (which is probably also not great).

Addresses #17129.

@chrisjrn chrisjrn added the category:internal CI, fixes for not-yet-released features, etc. label Oct 26, 2022
@chrisjrn chrisjrn marked this pull request as ready for review October 26, 2022 20:42
@chrisjrn
Copy link
Contributor Author

@thejcannon If I've missed anywhere that this warning could reasonably be displayed, do let me know!

Copy link
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

These warnings will definitely require followup: I'd feel a little bit better with a tracking ticket that covers actually using environments for lint/fix/fmt/check.

@chrisjrn chrisjrn merged commit a971882 into pantsbuild:main Oct 28, 2022
@chrisjrn chrisjrn deleted the chrisjrn/17129-lint-and-relatives branch October 28, 2022 15:12
@stuhood stuhood mentioned this pull request Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants