Allow unesecure node temporarily for manylinux container builds #21172

tobni · 2024-07-14T18:58:26Z

Renders github actions and env settings to continue to use node16 inside the containers that match the glibc (2.17) of manylinux_2014 builder images. The new default node version for gha requires a much higher version.

I checked if https://github.com/nodejs/unofficial-builds had node binaries we could use. It does not.

Based on #21133

tobni · 2024-07-14T19:11:41Z

Successful (but filled with warnings, none seem dangerous though) run: https://github.com/pantsbuild/pants/actions/runs/9929989447

benjyw

Thanks for fixing! LG mod an error message nit.

src/python/pants_release/generate_github_workflows.py

tobni · 2024-07-15T12:50:20Z

@benjyw Added a more helpful exception and rebased on upstream after merging #21133

…sbuild#21172) Renders github actions and env settings to continue to use node16 inside the containers that match the glibc (2.17) of manylinux_2014 builder images. The new default node version for gha requires a much higher version. I checked if https://github.com/nodejs/unofficial-builds had node binaries we could use. It does not. Based on pantsbuild#21133

WorkerPants · 2024-07-24T07:51:29Z

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

❌ 2.20.x

I was unable to cherry-pick this PR to 2.20.x, likely due to merge-conflicts.

Steps to Cherry-Pick locally

To resolve:

(Ensure your git working directory is clean)

Run the following script to reproduce the merge-conflicts:

git fetch https://github.com/pantsbuild/pants main \
  && git fetch https://github.com/pantsbuild/pants 2.20.x \
  && git checkout -b cherry-pick-21172-to-2.20.x FETCH_HEAD \
  && git cherry-pick 7452afeed46bc4a26c1ed0fe5508d669fb3d7985

Fix the merge conflicts and commit the changes
Run build-support/cherry_pick/make_pr.sh "21172" "2.20.x"

Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary.

❌ 2.21.x

I was unable to cherry-pick this PR to 2.21.x, likely due to merge-conflicts.

Steps to Cherry-Pick locally

To resolve:

(Ensure your git working directory is clean)

Run the following script to reproduce the merge-conflicts:

git fetch https://github.com/pantsbuild/pants main \
  && git fetch https://github.com/pantsbuild/pants 2.21.x \
  && git checkout -b cherry-pick-21172-to-2.21.x FETCH_HEAD \
  && git cherry-pick 7452afeed46bc4a26c1ed0fe5508d669fb3d7985

Fix the merge conflicts and commit the changes
Run build-support/cherry_pick/make_pr.sh "21172" "2.21.x"

Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary.

❌ 2.22.x

I was unable to cherry-pick this PR to 2.22.x, likely due to merge-conflicts.

Steps to Cherry-Pick locally

To resolve:

(Ensure your git working directory is clean)

Run the following script to reproduce the merge-conflicts:

git fetch https://github.com/pantsbuild/pants main \
  && git fetch https://github.com/pantsbuild/pants 2.22.x \
  && git checkout -b cherry-pick-21172-to-2.22.x FETCH_HEAD \
  && git cherry-pick 7452afeed46bc4a26c1ed0fe5508d669fb3d7985

Fix the merge conflicts and commit the changes
Run build-support/cherry_pick/make_pr.sh "21172" "2.22.x"

Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary.

When you're done manually cherry-picking, please remove the needs-cherrypick label on this PR.

Thanks again for your contributions!

🤖 Beep Boop here's my run link

huonw · 2024-07-25T10:51:22Z

I'll retry the cherrypick of this one once the remaining two cherrypicks of #21133 are in (#21203, #21204).

Renders github actions and env settings to continue to use node16 inside the containers that match the glibc (2.17) of manylinux_2014 builder images. The new default node version for gha requires a much higher version. I checked if https://github.com/nodejs/unofficial-builds had node binaries we could use. It does not. Based on #21133

WorkerPants · 2024-07-25T21:23:52Z

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

❌ 2.20.x

I was unable to cherry-pick this PR to 2.20.x, likely due to merge-conflicts.

Steps to Cherry-Pick locally

To resolve:

(Ensure your git working directory is clean)

Run the following script to reproduce the merge-conflicts:

git fetch https://github.com/pantsbuild/pants main \
  && git fetch https://github.com/pantsbuild/pants 2.20.x \
  && git checkout -b cherry-pick-21172-to-2.20.x FETCH_HEAD \
  && git cherry-pick 7452afeed46bc4a26c1ed0fe5508d669fb3d7985

Fix the merge conflicts and commit the changes
Run build-support/cherry_pick/make_pr.sh "21172" "2.20.x"

Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary.

❌ 2.21.x

I was unable to cherry-pick this PR to 2.21.x, likely due to merge-conflicts.

Steps to Cherry-Pick locally

To resolve:

(Ensure your git working directory is clean)

Run the following script to reproduce the merge-conflicts:

git fetch https://github.com/pantsbuild/pants main \
  && git fetch https://github.com/pantsbuild/pants 2.21.x \
  && git checkout -b cherry-pick-21172-to-2.21.x FETCH_HEAD \
  && git cherry-pick 7452afeed46bc4a26c1ed0fe5508d669fb3d7985

Fix the merge conflicts and commit the changes
Run build-support/cherry_pick/make_pr.sh "21172" "2.21.x"

Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary.

✔️ 2.22.x

Successfully opened #21209.

When you're done manually cherry-picking, please remove the needs-cherrypick label on this PR.

Thanks again for your contributions!

🤖 Beep Boop here's my run link

…ry-pick of #21172) (#21209) Renders github actions and env settings to continue to use node16 inside the containers that match the glibc (2.17) of manylinux_2014 builder images. The new default node version for gha requires a much higher version. I checked if https://github.com/nodejs/unofficial-builds had node binaries we could use. It does not. Based on #21133 Co-authored-by: Tobias Nilsson <tobias.jens.nilsson@gmail.com>

Renders github actions and env settings to continue to use node16 inside the containers that match the glibc (2.17) of manylinux_2014 builder images. The new default node version for gha requires a much higher version. I checked if https://github.com/nodejs/unofficial-builds had node binaries we could use. It does not. Based on #21133

…ry-pick of #21172) (#21211) Renders github actions and env settings to continue to use node16 inside the containers that match the glibc (2.17) of manylinux_2014 builder images. The new default node version for gha requires a much higher version. I checked if https://github.com/nodejs/unofficial-builds had node binaries we could use. It does not. Based on #21133 Co-authored-by: Tobias Nilsson <tobias.jens.nilsson@gmail.com>

…ry-pick of #21172) (#21212) Renders github actions and env settings to continue to use node16 inside the containers that match the glibc (2.17) of manylinux_2014 builder images. The new default node version for gha requires a much higher version. I checked if https://github.com/nodejs/unofficial-builds had node binaries we could use. It does not. Based on #21133 Co-authored-by: Tobias Nilsson <tobias.jens.nilsson@gmail.com>

tobni added category:internal CI, fixes for not-yet-released features, etc. release-notes:not-required PR doesn't require mention in release notes labels Jul 14, 2024

tobni mentioned this pull request Jul 14, 2024

Bump workflow actions for node20 #21133

Merged

tobni requested a review from benjyw July 14, 2024 19:05

tobni force-pushed the fix/allow-unesecure-node-temporarily branch from ac42bf1 to 9c8c88e Compare July 14, 2024 19:22

benjyw approved these changes Jul 14, 2024

View reviewed changes

src/python/pants_release/generate_github_workflows.py Outdated Show resolved Hide resolved

src/python/pants_release/generate_github_workflows.py Outdated Show resolved Hide resolved

tobni added 3 commits July 15, 2024 14:44

chore: Allow unsecure node in wheel actions

0032572

doc: Add a comment

c3cb2e4

chore: Raise a descriptive ValueError

acdba74

tobni force-pushed the fix/allow-unesecure-node-temporarily branch from 20cec3e to acdba74 Compare July 15, 2024 12:47

tobni enabled auto-merge (squash) July 15, 2024 12:48

tobni merged commit 7452afe into main Jul 15, 2024
25 checks passed

tobni deleted the fix/allow-unesecure-node-temporarily branch July 15, 2024 13:05

huonw mentioned this pull request Jul 24, 2024

CI uses node 16 actions via ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION for Linux x86-64 & arm64 builds #21195

Open

huonw added the needs-cherrypick label Jul 24, 2024

huonw added this to the 2.20.x milestone Jul 24, 2024

WorkerPants added the auto-cherry-picking-failed Auto Cherry-Picking Failed label Jul 24, 2024

huonw removed the needs-cherrypick label Jul 26, 2024

huonw mentioned this pull request Nov 6, 2024

actions/upload-artifacts@v3 is being removed (5 Dec 2024), affects Linux build-wheels jobs #21616

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow unesecure node temporarily for manylinux container builds #21172

Allow unesecure node temporarily for manylinux container builds #21172

tobni commented Jul 14, 2024 •

edited

Loading

tobni commented Jul 14, 2024

benjyw left a comment

tobni commented Jul 15, 2024

WorkerPants commented Jul 24, 2024

huonw commented Jul 25, 2024

WorkerPants commented Jul 25, 2024

Allow unesecure node temporarily for manylinux container builds #21172

Allow unesecure node temporarily for manylinux container builds #21172

Conversation

tobni commented Jul 14, 2024 • edited Loading

tobni commented Jul 14, 2024

benjyw left a comment

Choose a reason for hiding this comment

tobni commented Jul 15, 2024

WorkerPants commented Jul 24, 2024

❌ 2.20.x

❌ 2.21.x

❌ 2.22.x

huonw commented Jul 25, 2024

WorkerPants commented Jul 25, 2024

❌ 2.20.x

❌ 2.21.x

✔️ 2.22.x

tobni commented Jul 14, 2024 •

edited

Loading