Fix the release script. #6629
Fix the release script. #6629
Conversation
The latest version of wheel (0.32.1, just released) no longer writes the metadata.json file (see pypa/wheel#195). Instead, we must now read the version from the METADATA file. This change also tightens up the release docs a bit.
build-support/bin/release.sh
Outdated
| @@ -730,7 +730,7 @@ elif [[ "${test_release}" == "true" ]]; then | |||
| else | |||
| banner "Releasing packages to PyPi" && \ | |||
| ( | |||
| check_origin && check_clean_branch && check_pgp && check_owners && \ | |||
There was a problem hiding this comment.
Ooops yes, that was sloppy. In my defense, it was Saturday night...
| input_version = metadata['version'] | ||
| # Get version from the input whl's metadata. | ||
| input_version = None | ||
| metadata_file = os.path.join(workspace, dist_info_dir, 'METADATA') |
There was a problem hiding this comment.
Is there value in continuing to support rewriting both formats?
There was a problem hiding this comment.
Well, this is just where we get the original, qualified, version from. And the METADATA file is part of the wheel spec , so it was always OK to get the version from there.
|
We shouldn't be hitting wheel 0.32.1 since pex is broken under that and pants pins to 0.31.1. From my phone, so lazy question: did you determine how 0.32.1 was entering the picture at all? That seems like a bug. |
|
Turns out I was wrong about the underlying version that caused this - metadata.json was already removed in 0.31. I just noticed that 0.32.1 was published a few days ago, but the change to upgrade from 0.29 to 0.31.1 was also since the last release, so the former was a red herring. |
build-support/bin/release.sh
Outdated
| @@ -730,7 +730,7 @@ elif [[ "${test_release}" == "true" ]]; then | |||
| else | |||
| banner "Releasing packages to PyPi" && \ | |||
| ( | |||
| check_origin && check_clean_branch && check_pgp && check_owners && \ | |||
There was a problem hiding this comment.
Ooops yes, that was sloppy. In my defense, it was Saturday night...
|
Aha, ok. I have on my list killing this version mangling since setuptools supports it natively. I think I have my cue to resume and kill this code. |
The latest version of wheel (0.32.1, just released) no longer writes
the metadata.json file (see pypa/wheel#195).
Instead, we must now read the version from the METADATA file.
This change also tightens up the release docs a bit.