-
-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to grpcio 0.5.1. #9470
Bump to grpcio 0.5.1. #9470
Conversation
# Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests] # No JVM changes made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good thinking!
…ell? # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests] # No JVM changes made.
This is reviewable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fingers crossed that this fixes things
I think this dropped pantsbuild/grpc-rs@d106c61 which was fixing a fairly frequent flake we were seeing when getting cache hits - was that intentional? |
It was "somewhat intentional", in that we jumped two years ahead upstream, and I was willing to gamble that the implementation had changed enough that it was no longer necessary. But I did not confirm that it was not necessary. If you have a pointer to the pants PR that incorporated that change (in case it has more info on how its absence would exhibit at a high level in pants), that would be helpful? That way we can watch out for that symptom in the future. |
#6344 was the original PR - 🤞 |
Problem
#9395 occurs within our
grpcio
dependency, which is quite stale. Although #9395 is more likely to be related to changes in our executor (#9071) or to our transitive rust dependencies (#9122), getting on a more recent version of thegrpcio
crate might resolve the issue, or make it easier to report an issue.Solution
Bump to
0.5.1
with one patch (tikv/grpc-rs#457) pulled forward from our previous fork.[ci skip-jvm-tests] # No JVM changes made.