fix: include DPoP Proof "htm" in requestResource if GET is defaulted to

panva · Sep 9, 2024 · 23f7b49 · 23f7b49
1 parent a917cb6
commit 23f7b49
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/lib/helpers/request.js b/lib/helpers/request.js
@@ -79,7 +79,7 @@ module.exports = async function request(options, { accessToken, mTLS = false, DP
     opts.headers.DPoP = await this.dpopProof(
       {
         htu: `${url.origin}${url.pathname}`,
-        htm: options.method,
+        htm: options.method || 'GET',
         nonce: nonces.get(nonceKey),
       },
       DPoP,

diff --git a/test/client/dpop.test.js b/test/client/dpop.test.js
@@ -418,6 +418,27 @@ describe('DPoP', () => {
     const proof = this.httpOpts.headers.DPoP;
     const proofJWT = jose.decodeJwt(proof);
     expect(proofJWT).to.have.property('ath');
+    expect(proofJWT).to.have.property('htm', 'POST');
+  });
+
+  it('includes htm when GET is defaulted to', async function () {
+    const { privateKey } = await jose.generateKeyPair('ES256', { extractable: true });
+    nock('https://rs.example.com')
+      .matchHeader('Transfer-Encoding', isUndefined)
+      .matchHeader('Content-Length', isUndefined)
+      .get('/resource')
+      .reply(200, { sub: 'foo' });
+
+    await this.client.requestResource('https://rs.example.com/resource', 'foo', {
+      DPoP: privateKey,
+    });
+
+    expect(this.httpOpts).to.have.nested.property('headers.DPoP');
+
+    const proof = this.httpOpts.headers.DPoP;
+    const proofJWT = jose.decodeJwt(proof);
+    expect(proofJWT).to.have.property('ath');
+    expect(proofJWT).to.have.property('htm', 'GET');
   });
 
   it('is enabled for grant', async function () {