fix(typescript): add missing Strategy interface properties

closes #189

.github/workflows/test.yml

@@ -17,7 +17,6 @@ jobs:
           node-version: 12
       - run: npm install
       - run: npm run lint
-      - run: npx dtslint --onlyTestTsNext types
 
   test:
     name: Node Tests + Coverage

package.json

@@ -34,7 +34,7 @@
   "types": "types/index.d.ts",
   "scripts": {
     "coverage": "nyc mocha",
-    "lint": "eslint lib test",
+    "lint": "eslint lib test && npx dtslint --onlyTestTsNext types",
     "lint-fix": "eslint lib test --fix",
     "test": "mocha"
   },
@@ -53,7 +53,9 @@
     "@commitlint/cli": "^8.1.0",
     "@commitlint/config-conventional": "^8.1.0",
     "@types/got": "^9.6.7",
+    "@types/passport": "^1.0.1",
     "chai": "^4.2.0",
+    "dtslint": "^0.9.8",
     "eslint": "^6.2.2",
     "eslint-config-airbnb-base": "^14.0.0",
     "eslint-plugin-import": "^2.18.2",

types/index.d.ts

@@ -679,6 +679,14 @@ export interface StrategyOptions<TClient extends Client> {
 export class Strategy<TUser, TClient extends Client> {
   constructor(options: StrategyOptions<TClient>, verify: StrategyVerifyCallback<TUser> | StrategyVerifyCallbackUserInfo<TUser> |
     StrategyVerifyCallbackReq<TUser> | StrategyVerifyCallbackReqUserInfo<TUser>)
+
+  authenticate(req: any, options?: any): void;
+  success(user: any, info?: any): void;
+  fail(challenge: any, status: number): void;
+  fail(status: number): void;
+  redirect(url: string, status?: number): void;
+  pass(): void;
+  error(err: Error): void;
 }
 
 /**

types/openid-client-tests.ts

@@ -2,6 +2,7 @@ import { IncomingMessage } from 'http';
 
 // tslint:disable-next-line:no-relative-import-in-test
 import { custom, generators, Issuer, Client, Strategy, StrategyVerifyCallback, StrategyOptions, TokenSet, RegisterOther, IssuerMetadata } from './index.d';
+import passport from 'passport';
 
 async (req: IncomingMessage) => {
     // Custom HTTP options on the `Issuer` _c'tor_ (e.g. used for `Issuer.discover()`):
@@ -185,4 +186,9 @@ async (req: IncomingMessage) => {
     strategyOptions.client.myCustomMethod();
 
     const customStrategy = new CustomStrategy(strategyOptions, verify);
+
+    passport.use(
+        'oidc',
+        new Strategy({ client, params: { foo: 'bar ' } }, verify)
+    );
 };

types/tsconfig.json

@@ -7,6 +7,7 @@
     "noImplicitAny": true,
     "noImplicitThis": true,
     "strictNullChecks": true,
+    "esModuleInterop": true,
     "strictFunctionTypes": true,
     "baseUrl": "../",
     "typeRoots": [