Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with test topic using more than one file #701

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wmmihaa
Copy link

@wmmihaa wmmihaa commented Nov 11, 2022

Related to Test topic using more than one file will still only take one file #700

Copy link
Collaborator

@ErikMogensen ErikMogensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Micke! Long time!

Great that you found and reported this bug. However, it seems that this fix makes the number of sent messages equal to the number of selected files.

Please also provide a fix for queues to keep the behavior in sync.

@wmmihaa
Copy link
Author

wmmihaa commented Nov 12, 2022

However, it seems that this fix makes the number of sent messages equal to the number of selected files.

Would this not be the expected behavior?

@ErikMogensen
Copy link
Collaborator

The expected behavior is to send the number of messages that are set in the 'Message count' property on the 'Sender' tab. Since this may be confusing there is text explaining this behavior on the tab where you select the files.

I also replied to the issue, since it does not seem to be a bug.

@wmmihaa
Copy link
Author

wmmihaa commented Nov 13, 2022

In my humble opinion the Message Count setting makes sense when using Messages but is confusing when it comes to Files. I've made some changes automatically updating the Message Count property to the number of selected files, while setting it back to DefaultMessageCount (1) if any of the other tabs are selected.

I've made the update for both Queues and Topics

ServiceBusExplorer.mp4

@ErikMogensen
Copy link
Collaborator

ErikMogensen commented Nov 13, 2022

In my humble opinion

I have never seen you being humble 😄

Nice video and thanks for the addition to the queue control. I see two problems though. One is that if you have set the Message count to a higher value than the number of files it will be lowered. That could be fixed by making sure that the Message countis never lowered. The other problem is that changing the Message count may not be expected. That could perhaps be solved by changing the text that is above the list box and mentioning this behavior.

@paolosalvatori, @SeanFeldman do you have any input?

BTW, @wmmihaa were you able to open the controls in the Visual Studio designer? I am unable to do that. Most likely due to them inheriting from an abstract base class.

@wmmihaa
Copy link
Author

wmmihaa commented Nov 13, 2022

One is that if you have set the Message count to a higher value than the number of files it will be lowered.

Yes I was considering pointing this out, but thought less of it. But yes, if the user has selected the Message tab and sets the Message Count to any value but one, he or she might find it confusing when it's reset to "1" after selecting the Files tab and then back to Messages.

However, I think the confusion has to be put in perspective to the relation of selecting five files and hitting Send and only one message is transmitted. Or what happens if I select five files and set the Message Count to 7?

The "best" solution might be to keep a separate Message Count for each tab, but then again, perhaps a proper description is all you need as I think it's quite a rare occurance.

BTW, @wmmihaa were you able to open the controls in the Visual Studio designer? I am unable to do that. Most likely due to them inheriting from an abstract base class.

To tell you the truth I havn't open a WinForm application in 10 year so I don't know what to expect. But to answer your question, no I do not see a designer.

@stale stale bot added the wontfix label Jan 15, 2023
Repository owner deleted a comment from stale bot May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants