Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Grid Explorer - Adding Support for Event Grid V2 #737

Merged
merged 27 commits into from
Jun 10, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
f87a0d9
Event Grid Explorer - Adding support for Event Grid V2 in Service Bus…
t-wangamy Aug 16, 2023
cdd396b
Merge branch 'main' of https://github.com/paolosalvatori/ServiceBusEx…
t-wangamy Aug 16, 2023
e8e6791
Event Grid Explorer
t-wangamy Aug 16, 2023
b11b0c1
Event Grid Explorer
t-wangamy Aug 16, 2023
f0ad8fe
Event Grid Explorer
t-wangamy Aug 18, 2023
afe8a98
Wording
SeanFeldman Aug 18, 2023
38d75ec
Event Grid Explorer
t-wangamy Aug 18, 2023
e5b1c2a
Merge branch 'EventGridExplorer' of https://github.com/paolosalvatori…
t-wangamy Aug 18, 2023
7a7c463
Adhare to the license in the repo
SeanFeldman Nov 3, 2023
96e96e1
Fall back to the default API version
SeanFeldman Nov 5, 2023
f174fb4
Change tenantId
ErikMogensen Nov 7, 2023
5a76072
Added api-version commit
ErikMogensen Nov 7, 2023
bbc7b45
Change tenantId when logging in
ErikMogensen Nov 7, 2023
74bc13d
Merge pull request #747 from ErikMogensen/EventGridLogin
paolosalvatori Nov 9, 2023
8207abc
Improve UI event grid explorer (#752)
ErikMogensen Nov 20, 2023
fd86d19
Using Control plane sdk instead of generated files
harrieoriowo May 6, 2024
764e8cb
Finishing up the sdks
harrieoriowo May 16, 2024
2797407
Adding Filter UI
harrieoriowo May 20, 2024
a366114
Allowing multiple filters
harrieoriowo May 21, 2024
b7c3f54
Refining the explorer with proper error handling and the filters acce…
harrieoriowo May 25, 2024
e143794
Merge branch 'main' into EventGridExplorer
harrieoriowo May 25, 2024
1d43822
Resolving comments
harrieoriowo May 29, 2024
f1ed2e4
Merge branch 'EventGridExplorer' of https://github.com/paolosalvatori…
harrieoriowo May 29, 2024
46113e7
Resolving comments
harrieoriowo May 29, 2024
274791e
Removing custom exception and moving logic into filterfactory
harrieoriowo May 30, 2024
b45d3d5
Handling build warnings
harrieoriowo Jun 6, 2024
59b24b9
Build warnings resolved
harrieoriowo Jun 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions src/EventGridExplorerLibrary/Management/EventGridFilterFactory.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@

namespace EventGridExplorerLibrary
{
using System.Collections.Generic;
using global::Azure.ResourceManager.EventGrid.Models;
using System.Collections.Generic;

/// <summary>
/// Implementation of the EventGridFilterFactory class
Expand All @@ -14,7 +14,7 @@ namespace EventGridExplorerLibrary
public class EventGridFilterFactory
{
private FiltersConfiguration filtersConfiguration;

/// <summary>
/// Initializes a new instance of the <see cref="EventGridFilterFactory"/> class.
/// </summary>
Expand All @@ -23,7 +23,7 @@ public EventGridFilterFactory(FiltersConfiguration filtersConfiguration)
this.filtersConfiguration = filtersConfiguration;
}

public void FilterSelection()
public void FilterSelection()
{
if (OperatorType.Equals("Boolean equals")) { AddFilterForBoolEquals(); };
if (OperatorType.Equals("String is in")) { AddFilterForStringIn(); };
Expand All @@ -49,10 +49,10 @@ public void FilterSelection()
/// <inheritdoc/>
public void AddFilterForBoolEquals()
{
var filter = new BoolEqualsFilter
{
Key = Key,
Value = bool.Parse(Value)
var filter = new BoolEqualsFilter
{
Key = Key,
Value = bool.Parse(Value)
};

this.filtersConfiguration.Filters.Add(filter);
Expand Down Expand Up @@ -92,7 +92,7 @@ public void AddFilterForStringContains()
}

this.filtersConfiguration.Filters.Add(filter);
}
}

public void AddFilterForStringNotContains()
{
Expand All @@ -104,7 +104,7 @@ public void AddFilterForStringNotContains()
}

this.filtersConfiguration.Filters.Add(filter);
}
}

public void AddFilterForStringBeginsWith()
{
Expand All @@ -116,7 +116,7 @@ public void AddFilterForStringBeginsWith()
}

this.filtersConfiguration.Filters.Add(filter);
}
}

public void AddFilterForStringNotBeginsWith()
{
Expand All @@ -128,7 +128,7 @@ public void AddFilterForStringNotBeginsWith()
}

this.filtersConfiguration.Filters.Add(filter);
}
}

public void AddFilterForStringEndsWith()
{
Expand Down Expand Up @@ -156,7 +156,7 @@ public void AddFilterForStringNotEndsWith()

public void AddFilterForNumberLessThan()
{
var filter = new NumberLessThanFilter
var filter = new NumberLessThanFilter
{
Key = Key,
Value = double.Parse(Value)
Expand All @@ -167,7 +167,7 @@ public void AddFilterForNumberLessThan()

public void AddFilterForNumberGreaterThan()
{
var filter = new NumberGreaterThanFilter
var filter = new NumberGreaterThanFilter
{
Key = Key,
Value = double.Parse(Value)
Expand All @@ -189,7 +189,7 @@ public void AddFilterForNumberLessThanOrEquals()

public void AddFilterForNumberGreaterThanOrEquals()
{
var filter = new NumberGreaterThanOrEqualsFilter
var filter = new NumberGreaterThanOrEqualsFilter
{
Key = Key,
Value = double.Parse(Value)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,9 @@ private void btnCancel_Click(object sender, EventArgs e)
Close();
}

#pragma warning disable CS8632 // The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
private void HandleException(Exception? ex)
#pragma warning restore CS8632 // The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
{
if (string.IsNullOrWhiteSpace(ex?.Message))
{
Expand Down
2 changes: 2 additions & 0 deletions src/ServiceBusExplorer/Forms/CreateEventGridTopicForm.cs
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@ private void btnCancel_Click(object sender, EventArgs e)
Close();
}

#pragma warning disable CS8632 // The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
SeanFeldman marked this conversation as resolved.
Show resolved Hide resolved
private void HandleException(Exception? ex)
#pragma warning restore CS8632 // The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
{
if (string.IsNullOrWhiteSpace(ex?.Message))
{
Expand Down
10 changes: 2 additions & 8 deletions src/ServiceBusExplorer/Forms/EventGridConnectForm.Designer.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions src/ServiceBusExplorer/Forms/PublishEventForm.cs
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ private void btnCancel_Click(object sender, EventArgs e)
Close();
}

#pragma warning disable CS8632 // The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
harrieoriowo marked this conversation as resolved.
Show resolved Hide resolved
private void HandleException(Exception? ex)
#pragma warning restore CS8632 // The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
{
if (string.IsNullOrWhiteSpace(ex?.Message))
{
Expand Down
2 changes: 2 additions & 0 deletions src/ServiceBusExplorer/Forms/ReceiveEventForm.cs
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ private void btnCancel_Click(object sender, EventArgs e)
Close();
}

#pragma warning disable CS8632 // The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
harrieoriowo marked this conversation as resolved.
Show resolved Hide resolved
private void HandleException(Exception? ex)
#pragma warning restore CS8632 // The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
{
if (string.IsNullOrWhiteSpace(ex?.Message))
{
Expand Down