Improve UI event grid explorer #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikMogensen
requested review from
paolosalvatori and
SeanFeldman
as code owners
SeanFeldman
approved these changes
Nov 19, 2023
| RetryTimeout = txtRetryTimeout.Text != string.Empty ? int.Parse(txtRetryTimeout.Text) : 0; | ||
| ApiVersion = cboApiVersion.Text.Trim(); | ||
|
|
||
| var retryTimoutInSeconds = txtRetryTimeout.Text != string.Empty ? int.Parse(txtRetryTimeout.Text) : 0; |
There was a problem hiding this comment.
Suggested change
| var retryTimoutInSeconds = txtRetryTimeout.Text != string.Empty ? int.Parse(txtRetryTimeout.Text) : 0; | |
| int.TryParse(txtRetryTimeout.Text, out var retryTimoutInSeconds); |
ErikMogensen
merged commit 8207abc
into
paolosalvatori:EventGridExplorer
1 check passed
ErikMogensen
added a commit
that referenced
this pull request
Jun 10, 2024
* Event Grid Explorer - Adding support for Event Grid V2 in Service Bus Explorer Implemented Event Grid V2 library and components to view and manage Event Grid V2 entities * Updated Event Grid Explorer README * Made various fixes, including updating the connect form * Updated EventGridExplorer README and removed Service Bus root node menu strip from Event Grid root node * Adhare to the license in the repo * Fall back to the default API version * Change tenantId when logging in * Improve UI event grid explorer (#752) * Updated UI according to review. * Set default and cancel buttons. Changed window looks. * Changed the retry timout parsing * Using Control plane sdk instead of generated files * Adding Filter UI * Allowing multiple filters * Refining the explorer with proper error handling and the filters accepting values * Resolving comments * Removing custom exception and moving logic into filterfactory * Build warnings resolved --------- Co-authored-by: Sean Feldman <SeanFeldman@users.noreply.github.com> Co-authored-by: Erik Mogensen <ErikMogensen@users.noreply.github.com> Co-authored-by: Paolo Salvatori <paolos@microsoft.com> Co-authored-by: harrieoriowo <168222311+harrieoriowo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the menus on the Mainform:
On the Connect form I changed the order and width of the fields. I also made the API version a combo box. I did not the set list of tenants associated with the logged in account since I am pretty sure you need to log in the user first and that would be out of scope for this PR. However, I think that is the way to go.
I did not change the selection of the Cloud tenant, since I am not sure how that should work. I set the icon and made the OK button the Accept button and the Cancel button the Escape button.
For the three other dialogs I set the window position to CenterParent, window frame to Fixed and set Accept and Escape buttons:
