refactor: move code out of loop (GreptimeTeam#1657)

paomian · Oct 19, 2023 · 31de82b · 31de82b
1 parent 5056641
commit 31de82b
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/src/meta-srv/src/handler.rs b/src/meta-srv/src/handler.rs
@@ -183,19 +183,19 @@ impl HeartbeatHandlerGroup {
     ) -> Result<HeartbeatResponse> {
         let mut acc = HeartbeatAccumulator::default();
         let handlers = self.handlers.read().await;
+        let role = req
+            .header
+            .as_ref()
+            .and_then(|h| Role::from_i32(h.role))
+            .context(error::InvalidArgumentsSnafu {
+                err_msg: format!("invalid role: {:?}", req.header),
+            })?;
+
         for h in handlers.iter() {
             if ctx.is_skip_all() {
                 break;
             }
 
-            let role = req
-                .header
-                .as_ref()
-                .and_then(|h| Role::from_i32(h.role))
-                .context(error::InvalidArgumentsSnafu {
-                    err_msg: format!("invalid role: {:?}", req.header),
-                })?;
-
             if h.is_acceptable(role) {
                 h.handle(&req, &mut ctx, &mut acc).await?;
             }