Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change: Remove custom timestamp feature #861

Merged
merged 1 commit into from
Sep 6, 2016

Commits on Sep 4, 2016

  1. Breaking change: Remove custom timestamp feature

    A little over four years ago, a feature was added to allow users
    to change the name of the `versions.created_at` column. No reason
    was given at the time.
    
    #129
    
    There are three reasons why this should not be configurable:
    
    1. The standard column name in rails is `created_at`.
    2. The majority of the `versions` table is, and should be, an
       implementation detail of PT.
    3. This configuration option added moderate complexity to the
       library, and severe complexity to the test suite.
    jaredbeck committed Sep 4, 2016
    Configuration menu
    Copy the full SHA
    f963752 View commit details
    Browse the repository at this point in the history