Override sort configuration per key in configuration #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, I like that you stick purely to configuration here! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should resolve #43 by adding the ability to override the sort configuration per key in the
pyproject.tomlfile. This ability was not added to the command line switches, as I wasn't sure what a good way to represent this detailed configuration on the command line would be.Configuration overrides are matched using the fnmatch function so there is support for glob style wildcards when matching keys.
In order to support this functionality a data new class was added
TomlSortKeysthat keeps track of the full set of keys to a particularTomlSortItem, so that we can find the matching configuration overrides.