Skip to content

Commit

Permalink
Update todos
Browse files Browse the repository at this point in the history
  • Loading branch information
emhane committed Oct 2, 2024
1 parent 24a379b commit ad36bd6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 1 addition & 3 deletions crates/primitives/src/traits/block/body.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ pub trait BlockBody:
fn transactions(&self) -> &[Self::SignedTransaction];

/// Returns [`Withdrawals`] in the block, if any.
// todo: branch out into extension trait
fn withdrawals(&self) -> Option<&Withdrawals>;

/// Returns reference to uncle block headers.
Expand Down Expand Up @@ -94,9 +95,6 @@ pub trait BlockBody:
}

/// Calculates a heuristic for the in-memory size of the [`BlockBody`].
// todo: default impl when alloy prs merged
// <https://github.com/alloy-rs/alloy/pull/1414>
// <https://github.com/alloy-rs/alloy/pull/1415>
fn size(&self) -> usize;
}

Expand Down
4 changes: 1 addition & 3 deletions crates/primitives/src/traits/block/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ pub trait Block:
{
/// Header part of the block.
type Header: BlockHeader + Sealable;

/// The block's body contains the transactions in the block.
type Body: BlockBody;

Expand Down Expand Up @@ -101,8 +101,6 @@ pub trait Block:
}

/// Calculates a heuristic for the in-memory size of the [`Block`].
// todo: default impl when alloy prs merged
// <https://github.com/alloy-rs/alloy/pull/1414>
fn size(&self) -> usize;
}

Expand Down

0 comments on commit ad36bd6

Please sign in to comment.