-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eip4844: use alloy TxEip4844
#10624
eip4844: use alloy TxEip4844
#10624
Conversation
@tcoratger mind pointing out where exactly do we need |
If it's here reth/crates/primitives/src/transaction/sidecar.rs Lines 130 to 140 in 71e0178
self.transaction.encode_with_signature_fields(self.signature, out) ?
|
@klkvr nice just fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, pending conflicts caused by #10262
Co-authored-by: joshieDo <93316087+joshieDo@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on a local db and decoded existing txes fine 👍
Related #9484