Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transaction-pool: replace reth-primitive imports #10766

Merged
merged 3 commits into from
Sep 7, 2024

Conversation

estensen
Copy link
Contributor

@estensen estensen commented Sep 7, 2024

Progress on #10749

Changed all where direct drop-in-replacement was possible

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Sep 7, 2024
@estensen
Copy link
Contributor Author

estensen commented Sep 7, 2024

@mattsse find an replace in VSCode doesn't trigger format on save. Any idea how to enable that?

@mattsse
Copy link
Collaborator

mattsse commented Sep 7, 2024

I run this mostly manually and have an alias for nfmt=cargo +nightly fmt
so before I commit I run nfmt --all, it's muscle memory at this point

@estensen
Copy link
Contributor Author

estensen commented Sep 7, 2024

Have you considered adding a pre-commit hook to avoid this from happening?

@mattsse
Copy link
Collaborator

mattsse commented Sep 7, 2024

we have not, not a big fan of pre commit hooks
missed fmt is also not a big deal

@mattsse mattsse added this pull request to the merge queue Sep 7, 2024
Merged via the queue into paradigmxyz:main with commit 162f601 Sep 7, 2024
35 checks passed
@estensen estensen deleted the prim-tx-pool branch September 7, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants