Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rpc): LoadReceipt::build_transaction_receipt default impl to impl for EthApi #10786

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Sep 9, 2024

Ref #10632

LoadReceipt::build_transaction_receipt default impl to impl for EthApi. This prepares EthApi for returning network specific transaction type as opposed to AnyTransactionReceipt.

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library labels Sep 9, 2024
@emhane emhane requested a review from klkvr September 9, 2024 14:13
@emhane emhane added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit bbaccc2 Sep 11, 2024
35 checks passed
@emhane emhane deleted the emhane/mv-build-tx-receipt branch September 11, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants