Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(reth-primitives): use COMPACT_EXTENDED_IDENTIFIER_FLAG #10926

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

nkysg
Copy link
Contributor

@nkysg nkysg commented Sep 16, 2024

add COMPACT_IDENTIFIER_LEGACY, COMPACT_IDENTIFIER_EIP2930, COMPACT_IDENTIFIER_EIP1559, replace crates/primitives/src/transaction/mod.rs magic number

@nkysg nkysg requested a review from Rjected as a code owner September 16, 2024 01:00
@nkysg nkysg force-pushed the compact_identifier_reth-primitives branch from e382d37 to dd55679 Compare September 17, 2024 00:29
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdyt @joshieDo

@nkysg nkysg requested a review from mattsse September 17, 2024 12:16
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, double checked, lgtm

@mattsse mattsse added this pull request to the merge queue Sep 18, 2024
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Sep 18, 2024
Merged via the queue into paradigmxyz:main with commit e840238 Sep 18, 2024
35 checks passed
@nkysg nkysg deleted the compact_identifier_reth-primitives branch September 18, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants