impl Encodable2718, Decodable2718 for TransactionSigned

[klkvr]

First step towards #11153

Implements eip2718 traits for TransactionSigned, removes some of the method and uses methods provided by the trait instead:

• encode_enveloped -> encode_2718
• decode_enveloped -> decode_2718
• length_without_header -> encode_2718_len
• envelope_encoded -> encoded_2718
• encode_inner(buf, false) -> encode_2718
• encode_inner(buf, true) -> network_encode

This now uses decode_signed_fields methods which don't yet include partiy decoding fix from alloy-rs/alloy#1305, so we should probably merge this on next alloy release

[klkvr]

this is needed to avoid introducing eip2718 error variant on PayloadError. it can be made nicer once we have alloy-rs/alloy#1359

[mattsse]

cool, can we track these in a new issue so we don't forget?

[mattsse]

this is awesome!!

I suggest we get this in first and do the error cleanup once we have a new alloy bump

[mattsse]

cool, can we track these in a new issue so we don't forget?

[klkvr]

the ci is currently failing because of the issue addressed in alloy-rs/alloy#1367

@mattsse are we OK with including this after next alloy release?

[mattsse]

sorry about the conflicts -.-

let's ignore the test for now and track, doing a new alloy release asap anyway

[klkvr]

changed pooled tx decoding a bit, tests should pass now 230f53c

[klkvr]

ci is still failing due to lack of this check in 2718 impl

reth/crates/primitives/src/transaction/mod.rs

Lines 1436 to 1438 in ba4e411

	if !input_data.is_empty() {
	return Err(RlpError::UnexpectedLength)
	}

looks like it was added in #8296 and is only required for engine? should we instead only perform it there? adding it to decode_2718 would result in it being applied in Decodable impl too which might result in issues with decoding of eg lists of transactions

[klkvr]

addressed in f8f88ae by removing those tests and adding this checks to engine code handling decoding of transactions

[mattsse]

lgtm, we can do the Eip2718Error simplifications separately?

[klkvr]

lgtm, we can do the Eip2718Error simplifications separately?

updated in b5e2871