Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): define traits for primitives Block and BlockBody #11411

Merged
merged 3 commits into from
Oct 2, 2024
Merged

chore(sdk): define traits for primitives Block and BlockBody #11411

merged 3 commits into from
Oct 2, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Oct 2, 2024

  • Defines trait Block based on reth_primitives::Block
  • Defines trait BlockBody based on reth_primitives::BlockBody
  • Defines new traits in new module reth_primitives::traits, until to avoid moving SealedBlock and BlockWithSenders from reth-primitives into reth-primitives-traits in this PR.

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-sdk Related to reth's use as a library labels Oct 2, 2024
@emhane emhane requested a review from Rjected as a code owner October 2, 2024 09:38
@emhane emhane mentioned this pull request Oct 2, 2024
Merged
mattsse
mattsse approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments on #11399

but I like this a lot and we should proceed with this

@emhane emhane enabled auto-merge October 2, 2024 12:28
@emhane emhane added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit d36683d Oct 2, 2024
35 checks passed
@emhane emhane deleted the emhane/block-primitive-abstraction branch October 2, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse