Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): define FullSignedTx trait #12327

Merged
merged 1 commit into from
Nov 6, 2024
Merged

chore(sdk): define FullSignedTx trait #12327

merged 1 commit into from
Nov 6, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Nov 5, 2024

Ref #11253

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-sdk Related to reth's use as a library labels Nov 5, 2024
@emhane emhane mentioned this pull request Nov 5, 2024
Merged
mattsse
mattsse approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makese sense imo

@emhane emhane added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit 660ca38 Nov 6, 2024
41 checks passed
@emhane emhane deleted the emhane/full-signed-tx branch November 6, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse