feat: add TaskSpawner to spawn validation requests as blocking
#12543
+91
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Nov 15, 2024
crates/rpc/rpc/src/validation.rs
Outdated
Comment on lines
394
to
434
| let (tx, rx) = oneshot::channel(); | ||
| let this = self.clone(); | ||
|
|
||
| self.task_spawner.spawn_blocking(Box::pin(async move { |
crates/rpc/rpc/src/validation.rs
Outdated
Comment on lines
394
to
433
| let (tx, rx) = oneshot::channel(); | ||
| let this = self.clone(); | ||
|
|
There was a problem hiding this comment.
what I'd like to here is is wrap the entire function into a spawn_blocking call, effectively duplicating the function: trait + native and then the trait function just calls Self::
for example
reth/crates/rpc/rpc/src/debug.rs
Lines 938 to 940 in 870ffae
There was a problem hiding this comment.
Gotcha updated so that we wrap the entire function into a spawn_blocking call and calling it using Self::
ftupas
force-pushed
the
feat/spawn-validation-requests-as-blocking
branch
from
ac8c19b
to
c234678
Compare
mattsse
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr does the following:
task_spawnerto theValidationApiInnerstructvalidate_builder_submission_v3andvalidate_builder_submission_v4