Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add kzg_to_versioned_hash #4085

Merged
merged 10 commits into from
Aug 10, 2023
Merged

feat: add kzg_to_versioned_hash #4085

merged 10 commits into from
Aug 10, 2023

Conversation

PatStiles
Copy link
Contributor

This adds kzg_to_versioned_hash as a helper method to reth_primitives blobfee module to eip4844.

@PatStiles PatStiles requested a review from gakonst as a code owner August 5, 2023 22:21
@codecov
Copy link

codecov bot commented Aug 5, 2023 •
edited
Loading

Codecov Report

Merging #4085 (380571c) into main (4de1ff0) will decrease coverage by 0.03%.
Report is 8 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/consensus/common/src/validation.rs 71.22% <ø> (ø)
crates/primitives/src/constants/eip4844.rs 100.00% <ø> (ø)
crates/primitives/src/eip4844.rs 0.00% <0.00%> (ø)
crates/primitives/src/header.rs 95.58% <ø> (ø)
crates/primitives/src/lib.rs 100.00% <ø> (ø)

... and 17 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.85% <0.00%> (-0.02%) ⬇️
unit-tests 64.05% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.94% <ø> (ø)
blockchain tree 82.83% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.75% <ø> (ø)
trie 94.71% <ø> (ø)
txpool 47.62% <ø> (-0.04%) ⬇️
networking 77.69% <ø> (-0.04%) ⬇️
rpc 58.69% <ø> (-0.02%) ⬇️
consensus 63.76% <ø> (ø)
revm 32.26% <ø> (ø)
payload builder 6.57% <ø> (ø)
primitives 87.85% <0.00%> (-0.07%) ⬇️

@mattsse mattsse requested a review from Rjected August 6, 2023 10:54
Rjected
Rjected requested changes Aug 7, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainly nits and comments on style

crates/primitives/src/eip4844.rs Outdated Show resolved Hide resolved
crates/primitives/src/eip4844.rs Outdated Show resolved Hide resolved
crates/primitives/src/eip4844.rs Outdated Show resolved Hide resolved
@Rjected
Copy link
Member

Rjected commented Aug 7, 2023

needs to be updated now that #4084 is merged

Rjected
Rjected requested changes Aug 9, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small nit, otherwise this looks good to me

crates/primitives/src/eip4844.rs Outdated Show resolved Hide resolved
@PatStiles PatStiles closed this Aug 10, 2023
@PatStiles PatStiles force-pushed the feat/add_kzg_to_versioned_hash branch from d0de8c5 to 4de1ff0 Compare August 10, 2023 02:48
@Rjected Rjected reopened this Aug 10, 2023
Rjected
Rjected requested changes Aug 10, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, just some small things that were probably due to rebase. after making changes make sure to run cargo +nightly fmt

crates/primitives/Cargo.toml Outdated Show resolved Hide resolved
crates/primitives/Cargo.toml Show resolved Hide resolved
Rjected
Rjected approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, LGTM!

@Rjected Rjected added this pull request to the merge queue Aug 10, 2023
Merged via the queue into paradigmxyz:main with commit c412f39 Aug 10, 2023
24 checks passed
@Rjected Rjected mentioned this pull request Aug 17, 2023
Closed
alessandromazza98 pushed a commit to alessandromazza98/reth that referenced this pull request Aug 19, 2023
@PatStiles @Rjected @alessandromazza98
feat: add kzg_to_versioned_hash (paradigmxyz#4085)
e184806 
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PatStiles @Rjected