Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add discovery port function #4543

Merged
merged 1 commit into from
Sep 10, 2023
Merged

feat: add discovery port function #4543

merged 1 commit into from
Sep 10, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 10, 2023

🤖 Generated by Copilot at 3053748

This pull request adds a default socket address for the discv4 discovery module and updates the network configuration to use it. It also improves the API and documentation of the network and discv4 crates.

@mattsse mattsse added C-enhancement New feature or request C-debt Refactor of code section that is hard to understand or maintain labels Sep 10, 2023
@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Merging #4543 (3053748) into main (2de63c6) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 42.85%.

Impacted file tree graph

Files Changed Coverage Δ
crates/net/discv4/src/lib.rs 64.95% <ø> (+0.06%) ⬆️
crates/net/network/src/config.rs 64.63% <42.85%> (-1.90%) ⬇️

... and 5 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.68% <42.85%> (-0.02%) ⬇️
unit-tests 63.99% <42.85%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.83% <ø> (ø)
blockchain tree 83.58% <ø> (ø)
pipeline 90.56% <ø> (ø)
storage (db) 75.32% <ø> (ø)
trie 94.88% <ø> (ø)
txpool 47.99% <ø> (+0.48%) ⬆️
networking 77.39% <42.85%> (-0.07%) ⬇️
rpc 57.37% <ø> (ø)
consensus 63.40% <ø> (ø)
revm 31.67% <ø> (ø)
payload builder 6.34% <ø> (ø)
primitives 86.52% <ø> (+0.01%) ⬆️

@mattsse mattsse merged commit fc9f116 into main Sep 10, 2023
25 checks passed
@mattsse mattsse deleted the matt/add-discovery-port-fn branch September 10, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant