New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(primitives): effective_gas_tip and effective_tip_per_gas functions together #5144

Merged

mattsse merged 12 commits into paradigmxyz:main from DoTheBestToGetTheBest:refactor

Nov 2, 2023

+27 −39

Contributor

DoTheBestToGetTheBest commented Oct 23, 2023

Should close this #5141

DoTheBestToGetTheBest added 5 commits

October 23, 2023 10:15


          Update mod.rs

6cf8493


          Update fees.rs

8c708bb


          Update bundle.rs

64051ae


          Update gas_oracle.rs

ccf8505


          Update traits.rs

0f3835b

DoTheBestToGetTheBest requested review from mattsse, Rjected and gakonst as code owners

October 23, 2023 17:18

DoTheBestToGetTheBest added 3 commits

October 23, 2023 10:36


          Update lib.rs

518bed6


          Update mod.rs

0402b17


          Update lib.rs

f0163ea

codecov bot commented Oct 23, 2023 •

edited

Loading

Codecov Report

Merging #5144 (f0163ea) into main (36dde36) will decrease coverage by 55.05%.
Report is 77 commits behind head on main.
The diff coverage is 40.00%.

❗ Current head f0163ea differs from pull request most recent head 2569e83. Consider uploading reports for the commit 2569e83 to get more accurate results

Files	Coverage Δ
crates/transaction-pool/src/traits.rs	`35.16% <100.00%> (-8.43%)`	⬇️
crates/primitives/src/transaction/mod.rs	`25.13% <87.50%> (-54.00%)`	⬇️
crates/rpc/rpc/src/eth/api/fees.rs	`0.00% <0.00%> (-49.24%)`	⬇️
crates/rpc/rpc/src/eth/bundle.rs	`0.00% <0.00%> (ø)`
crates/payload/basic/src/lib.rs	`0.00% <0.00%> (ø)`
crates/rpc/rpc-types-compat/src/transaction/mod.rs	`0.00% <0.00%> (ø)`
crates/rpc/rpc/src/eth/gas_oracle.rs	`20.45% <0.00%> (-19.32%)`	⬇️

... and 449 files with indirect coverage changes

Flag	Coverage Δ
integration-tests	`12.94% <40.00%> (-4.12%)`	⬇️
unit-tests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
reth binary	`6.18% <ø> (-24.40%)`	⬇️
blockchain tree	`0.00% <ø> (-80.83%)`	⬇️
pipeline	`0.00% <ø> (-88.37%)`	⬇️
storage (db)	`15.20% <ø> (-59.38%)`	⬇️
trie	`0.00% <ø> (-94.97%)`	⬇️
txpool	`25.75% <100.00%> (-30.02%)`	⬇️
networking	`26.47% <ø> (-51.89%)`	⬇️
rpc	`10.65% <0.00%> (-47.05%)`	⬇️
consensus	`0.00% <ø> (-63.02%)`	⬇️
revm	`0.49% <ø> (-23.99%)`	⬇️
payload builder	`0.00% <0.00%> (-7.96%)`	⬇️
primitives	`15.28% <87.50%> (-69.50%)`	⬇️

mattsse assigned Rjected

Collaborator

mattsse commented Oct 25, 2023

Rjected requested changes

View reviewed changes

Member

Rjected left a comment

Good start, just have some small changes so far

crates/primitives/src/transaction/mod.rs Outdated

-                      let base_fee = base_fee as u128;
+                  pub fn effective_tip_per_gas(&self, base_fee: Option<u64>) -> Option<u128> {
+                      // Convert the base fee to u128 if present, or provide a default value
+                      let base_fee = base_fee.map_or(0, |fee| fee as u128);

Member

Rjected Oct 25, 2023

Should use unwrap_or_default here

Contributor Author

DoTheBestToGetTheBest Oct 25, 2023

Should use unwrap_or_default here

Hello, thank you for these information. Deleted comments + used unwrap_or_default :)

crates/primitives/src/transaction/mod.rs Outdated Show resolved Hide resolved


          Update mod.rs

f9049e6

DoTheBestToGetTheBest requested a review from Rjected

October 25, 2023 23:52

Rjected requested changes

View reviewed changes

Member

Rjected left a comment

just one change that should have been caught earlier, then this looks good

crates/primitives/src/transaction/mod.rs Outdated Show resolved Hide resolved


          Update mod.rs

DoTheBestToGetTheBest requested a review from Rjected

October 27, 2023 18:06

Contributor Author

DoTheBestToGetTheBest commented Oct 27, 2023

just one change that should have been caught earlier, then this looks good

Hey, thank you for this. I changed the missing part :)

Rjected requested changes

View reviewed changes

Member

Rjected left a comment

smol style nit

crates/primitives/src/transaction/mod.rs Outdated Show resolved Hide resolved


          Update mod.rs

f71b5d6

DoTheBestToGetTheBest requested a review from Rjected

October 29, 2023 13:34

Rjected approved these changes

View reviewed changes

Member

Rjected left a comment

this looks good to me now

mattsse approved these changes

View reviewed changes

crates/primitives/src/transaction/mod.rs Outdated Show resolved Hide resolved

crates/primitives/src/transaction/mod.rs Outdated Show resolved Hide resolved


          Update crates/primitives/src/transaction/mod.rs

2569e83

mattsse enabled auto-merge

November 2, 2023 14:23

mattsse added this pull request to the merge queue

Merged via the queue into paradigmxyz:main with commit 93fc2e2

22 checks passed

mattsse added a commit that referenced this pull request


          feat(primitives): effective_gas_tip and effective_tip_per_gas functio…

042a21d

…ns together (#5144)

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet