feat(cli): count the appearances of opcode and opcode sets #5211
Conversation
Co-authored-by: Alessandro Mazza <alessandromazza98@users.noreply.github.com>
Co-authored-by: Alessandro Mazza <alessandromazza98@users.noreply.github.com>
Co-authored-by: Alessandro Mazza <alessandromazza98@users.noreply.github.com>
Co-authored-by: Alessandro Mazza <alessandromazza98@users.noreply.github.com>
bin/reth/src/count_opcodes/mod.rs
Outdated
| test_bytecode | ||
| } | ||
|
|
||
| fn all_opcodes_test_string() -> String { |
There was a problem hiding this comment.
This can be quite noisy in the file, however we wanted to make it as easy as possible to read and modify this test opcodes string if needed
bin/reth/src/cli/mod.rs
Outdated
| @@ -163,6 +164,9 @@ pub enum Commands<Ext: RethCliExt = ()> { | |||
| /// Scripts for node recovery | |||
| #[command(name = "recover")] | |||
| Recover(recover::Command), | |||
| /// Script for counting opcodes occurrencies | |||
| #[command(name = "count-opcodes")] | |||
| CountOpcodes(count_opcodes::Command), | |||
There was a problem hiding this comment.
I'd put this under debug or something like that since it's not really relevant to normal node ops
bin/reth/src/count_opcodes/mod.rs
Outdated
|
|
||
| let mut opcode_counter = OpCodeCounter::new(); | ||
|
|
||
| info!("start opcodes processing..."); |
There was a problem hiding this comment.
These info!'s are not rly necessary, I imagine it doesn't take a long time?
bin/reth/src/count_opcodes/mod.rs
Outdated
| } | ||
|
|
||
| fn print_counts(&self, size: usize) { | ||
| println!("Single opcodes:"); |
There was a problem hiding this comment.
nit: we can use the table layout that we also use for the db commands here 😄
onbjerg
added
C-enhancement
|
Hey @onbjerg, we should have addressed all your reviews. Now tables are printed using |
thedevbirb
force-pushed
the
count_opcodes
branch
from
3a8cdd9
to
46dc762
Compare
|
Hi @DaniPopes! Thanks for the review, now it should be better. |
thedevbirb
force-pushed
the
count_opcodes
branch
from
b97ce1c
to
890c1af
Compare
|
Hey, sorry to bother you. Is there anything left we may do for this PR? |
There was a problem hiding this comment.
Nit: Can you extract this to an example/ of using the node as a library, with the OpcodeCounter in a separate file and some explanation on the motivation of why opcode occurences are useful? cc @sslivkoff for parquet
|
something similar is available in the geth trigram / bigram / unigram tracer with would love to have this new implementation accessible over rpc somehow |
|
Thanks! We'll look into it |
|
I moved it into the |
github-actions
bot
added
the
S-stale
Closes #5067. This PR co-authored by @alessandromazza98 introduces a new command called
count-opcodesthat returns thetaketop occurrences of opcodes and tuples of opcodes.Here below is an example of the result of running this command on a few blocks on Sepolia:
