feat: rlpx multiplexing #5413
Merged
feat: rlpx multiplexing #5413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
force-pushed
the
matt/rlpx-multiplexing
branch
from
0e12857
to
7742793
Compare
Rjected
approved these changes
Nov 22, 2023
Comment on lines
+291
to
+317
| // TODO optimize this by keeping a better index | ||
| let mut lowest_satellite = None; | ||
| // find the protocol with the lowest offset that is greater than the message | ||
| // offset | ||
| for (i, proto) in this.satellites.iter().enumerate() { | ||
| let proto_offset = proto.cap.relative_message_id_offset(); | ||
| if proto_offset >= offset { | ||
| if let Some((_, lowest_offset)) = lowest_satellite { | ||
| if proto_offset < lowest_offset { | ||
| lowest_satellite = Some((i, proto_offset)); | ||
| } | ||
| } else { | ||
| lowest_satellite = Some((i, proto_offset)); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if let Some((idx, lowest_offset)) = lowest_satellite { | ||
| if lowest_offset < this.primary_capability.relative_message_id_offset() | ||
| { | ||
| // delegate to satellite | ||
| this.satellites[idx].send_raw(msg); | ||
| continue | ||
| } | ||
| } | ||
| // delegate to primary | ||
| let _ = this.to_primary.send(msg); |
There was a problem hiding this comment.
yeah, an index would be nice for this
| Poll::Ready(Some(msg)) => { | ||
| this.out_buffer.push_back(msg); | ||
| } | ||
| Poll::Ready(None) => return Poll::Ready(None), |
There was a problem hiding this comment.
This was confusing to me at first, but if any of the streams are closed, we
need to return Poll::Ready(None)
|
will merge and push smaller followups |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support for multiplexing rlpx protocols
this is tailored for custom protocols in reth-network
this needs several followups but should be included to unblock