Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc-testing-utils) : implement debug_traceCall JSON-RPC method #5418

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

DoTheBestToGetTheBest
Copy link
Contributor

this PR Introduced debug_trace_call_json in DebugApiExt. Now, tracing calls is simpler and more insightful! 🚀🔍

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue with this is that both sides, client/server are still symmetrical here.

what we want is a way to easily send request params as string

like request but with a str argument, so we can call it like `"debug_traceCall", "["0x...",...]"

@DoTheBestToGetTheBest
Copy link
Contributor Author

DoTheBestToGetTheBest commented Nov 13, 2023

ke request but with a str argument, so we can call it like `"debug_traceCall", "["0x...",...]

Ty lot for your review boss!

i think i got it, we don't need anymore to specify that we're using CallRequest for our params, going to try this, thanks

@mattsse mattsse added this pull request to the merge queue Nov 24, 2023
Merged via the queue into paradigmxyz:main with commit 2624f46 Nov 24, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants