feat(storage): report backtrace on long-lived transactions #5537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Nov 23, 2023
Comment on lines
28
to
29
| /// Duration after which we emit the log about long-lived database transactions. | ||
| const LONG_TRANSACTION_DURATION: Duration = Duration::from_secs(30); |
There was a problem hiding this comment.
I think we can do this, if the tx has been open for that long, the perf hit of backtrace capture is negligible imo
shekhirin
added
C-enhancement
This reverts commit 1252dce.
mattsse
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the PR title.
It's hard to identify the source of long-lived transactions, and they bother us because they are growing freelist. So let's capture and log the full backtrace once the transaction duration reaches the threshold of 30 seconds.