Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bin/args): enhance transactionpool with --txpool.nolocals Flag #5538

Merged
merged 17 commits into from
Nov 26, 2023

Conversation

DoTheBestToGetTheBest
Copy link
Contributor

This PR introduces the --txpool.nolocals flag to improve transaction pool behavior by enabling the disabling of local exemptions for locally submitted transactions.

ref #5520

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks pretty good already.

please be mindful of whether the issue has already been assigned ;)

crates/transaction-pool/src/config.rs Outdated Show resolved Hide resolved
crates/transaction-pool/src/validate/eth.rs Outdated Show resolved Hide resolved
@DoTheBestToGetTheBest
Copy link
Contributor Author

this looks pretty good already.

please be mindful of whether the issue has already been assigned ;)

don't worry, i asked him already if i can take the issue, he was okey with this :)

@DoTheBestToGetTheBest
Copy link
Contributor Author

DoTheBestToGetTheBest commented Nov 22, 2023

just a realy big noob question (and excuse me for this) but cargo check doesn't work in bin/reth, is this normal ?

@mattsse
Copy link
Collaborator

mattsse commented Nov 23, 2023

for bin try with --features ethereum

@DoTheBestToGetTheBest
Copy link
Contributor Author

removed the container type

@DoTheBestToGetTheBest
Copy link
Contributor Author

for bin try with --features ethereum

ty lot for this, solved my problem

ty also for your review!

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, last doc nits

crates/transaction-pool/src/validate/eth.rs Outdated Show resolved Hide resolved
crates/transaction-pool/src/validate/eth.rs Outdated Show resolved Hide resolved
@mattsse mattsse added C-enhancement New feature or request A-tx-pool Related to the transaction mempool labels Nov 23, 2023
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,
after thinking about this a bit more and also considering the upcoming --locals flag, I think your previous approach with a new wrapper types was better.

I've added this design back real quick

@mattsse mattsse added this pull request to the merge queue Nov 26, 2023
Merged via the queue into paradigmxyz:main with commit 8667c33 Nov 26, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants