Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: get almost rid of reth-primitives in tracer impl #5544

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 23, 2023

phase out most of reth-primitives and use alloy imports

still depends on Account and acceslist types for which we need a solution
could be replaced with the rpc types variant I believe

cc @Evalir

@mattsse mattsse requested a review from Evalir November 23, 2023 13:20
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Nov 23, 2023
@mattsse mattsse requested a review from onbjerg November 23, 2023 13:49
Copy link
Collaborator

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

short! just a nit icymi

crates/revm/revm-inspectors/src/stack/mod.rs Show resolved Hide resolved
@mattsse mattsse merged commit 7c148b4 into main Nov 23, 2023
28 checks passed
@mattsse mattsse deleted the matt/get-almost-rid-of-reth-primitives branch November 23, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants