Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reuse alloy Log type #5548

Merged
merged 1 commit into from
Nov 23, 2023
Merged

chore: reuse alloy Log type #5548

merged 1 commit into from
Nov 23, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 23, 2023

no need for another log type, can reuse alloy's

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Nov 23, 2023
Evalir
Evalir approved these changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less types good

@mattsse mattsse added this pull request to the merge queue Nov 23, 2023
Merged via the queue into main with commit fc9bdea Nov 23, 2023
27 checks passed
@mattsse mattsse deleted the matt/remove-custom-log-type branch November 23, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evalir Evalir Evalir approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Evalir