Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(rpc): Use block_with_senders in tracing #5630

Merged
merged 5 commits into from
Dec 1, 2023
Merged

perf(rpc): Use block_with_senders in tracing #5630

merged 5 commits into from
Dec 1, 2023

Conversation

yash-atreya
Copy link
Contributor

Addresses #5497

Updated call_many and transaction_by_block_and_tx_index to use block_with_senders removing the need for recovering txns.

@yash-atreya yash-atreya changed the title Block with senders in tracing Perf(rpc): Use block_with_senders in tracing Nov 29, 2023
@yash-atreya yash-atreya changed the title Perf(rpc): Use block_with_senders in tracing perf(rpc): Use block_with_senders in tracing Nov 29, 2023
gakonst
gakonst approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@gakonst gakonst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it - cc @mattsse -- with these in we should re-run all our RPC benchmarks I think

mattsse
mattsse requested changes Nov 29, 2023
View reviewed changes
crates/rpc/rpc/src/eth/api/call.rs Outdated Show resolved Hide resolved
mattsse
mattsse requested changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, last nit

crates/rpc/rpc/src/eth/api/call.rs Outdated Show resolved Hide resolved
@yash-atreya yash-atreya mentioned this pull request Dec 1, 2023
Closed
@mattsse mattsse enabled auto-merge December 1, 2023 11:50
@mattsse mattsse added this pull request to the merge queue Dec 1, 2023
Merged via the queue into paradigmxyz:main with commit 1067bb3 Dec 1, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst gakonst approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yash-atreya @gakonst @mattsse