-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include apache licenced fastrlp as reth-rlp #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no authors in the original: https://docs.rs/crate/fastrlp/0.1.2/source/Cargo.toml.orig
should we make a note in the readme?
Will add the note |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. We'll need to derive this in ethers core types though? If we're doing this, maybe we should just sprint on ruint
usage over Primitive Types & Ethers Core? And get this fastrlp there?
* add l1_fee field to `Receipt` Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * scroll consensus Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * feat: scroll execution strategy Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * feat: expose `verify_receipts` from reth-ethereum-consensus Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * feat: add `reth-scroll-evm` crate to avoid cyclic dep Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * improve curie fork application + test Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * integrate l1 fee Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * add `ScrollEvmConfig` Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * add tests for `ScrollEvmConfig` Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * add tests for `ScrollExecutionStrategy` Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * add l1 message test for `ScrollExecutionStrategy` Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * add legacy tx execution test for `ScrollExecutionStrategy` Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * use revm scroll fork Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * introduce `ScrollExecutionStrategyFactory` Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * feat: patch revm crate to scroll fork Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * fix: lints Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * fix: deny Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * answer comments Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * fill `TxEnv.rlp_bytes` only for !is_l1_message Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * lints Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * switch revm to scroll default branch Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * fix: deny Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * fix: remove alloy-sol-types patch Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * feat: propagate scroll chain spec in execution Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * fix: scroll ci Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * chore: bump `trust-dns-resolver` to 0.25 alpha4 to fix deny Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * fix: propagate serde feature Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * fix: docs Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * answer comments Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * lint Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> * answer comments Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com> --------- Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Including apache licenced fastrlp from here: https://docs.rs/fastrlp/0.1.2/fastrlp/index.html
Bloom filters need to be enabled behind
ethereum-types
, they are not commented out.