Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NetworkHandle get access to TransactionsHandle #6780

Merged
merged 5 commits into from
Feb 27, 2024

Conversation

qiweiii
Copy link
Contributor

@qiweiii qiweiii commented Feb 24, 2024

fix #5598

crates/net/network/src/network.rs Outdated Show resolved Hide resolved
crates/net/network/src/network.rs Outdated Show resolved Hide resolved
crates/net/network/src/network.rs Outdated Show resolved Hide resolved
@qiweiii
Copy link
Contributor Author

qiweiii commented Feb 26, 2024

Made some updates

@qiweiii qiweiii requested a review from mattsse February 27, 2024 01:17
@qiweiii qiweiii changed the title feat: helper trait for Network to get access to TransactionsHandle feat: NetworkHandle get access to TransactionsHandle Feb 27, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice,

last nit

crates/net/network/src/network.rs Outdated Show resolved Hide resolved
crates/net/network/src/network.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Feb 27, 2024
Merged via the queue into paradigmxyz:main with commit a27626c Feb 27, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new helper trait for Network to get access to TransactionsHandle
2 participants