-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
txpool: track failed delete blobs in cleanup #6952
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that makes sense,
I'd like to use a struct container type so we can easily add more fields, perhaps we also want to rescan the dir
Signed-off-by: jsvisa <delweng@gmail.com>
… stat Signed-off-by: jsvisa <delweng@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last pedantic nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: jsvisa <delweng@gmail.com>
As the blob files were deleted in async mode, and the
cleanup
will truly delete the under blob files, so we should track theblobstore_failed_deletes
incleanup
instead ofdelete_blob{s}