Add new mempool panels + existing mempool panels to new dashboard #7014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Mar 6, 2024
shekhirin
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Nice! One small thing: we refer to the mempool as transaction pool throughout the codebase, can we do the same in the dashboard?
reth/etc/grafana/dashboards/reth-mempool.json
Line 2520 in b628251
Also would appreciate a screenshot of this dashboard in the PR, as I didn't test it as well.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reth-mempool.reth-mempooldashboard.As discussed with @shekhirin, updating the grafana dashboard is painful so long as it is not modular. Every new panel changes at least the grid position of existing panels placed lower than it.