Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: condition export of generate_blob_sidecar on its cfg #7023

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Mar 6, 2024

Fixes the following warning when running cargo test -p reth-primitives test_blob_transaction_decode:

warning: unreachable `pub` item
   --> crates/primitives/src/transaction/sidecar.rs:495:1
    |
495 | pub fn generate_blob_sidecar(blobs: Vec<Blob>) -> BlobTransactionSidecar {
    | ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    | |
    | help: consider restricting its visibility: `pub(crate)`
    |
    = help: or consider exporting it for use by other crates
    = note: requested on the command line with `-W unreachable-pub`

@Rjected Rjected added C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test labels Mar 6, 2024
@Rjected Rjected requested a review from gakonst as a code owner March 6, 2024 22:53
@Rjected Rjected enabled auto-merge March 6, 2024 23:01
@Rjected Rjected added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit 3308ddb Mar 6, 2024
26 checks passed
@Rjected Rjected deleted the dan/unreachable-pub-sidecar branch March 6, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants