Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): implement BundleStateDataProvider for BundleStateWithReceipts #8282

Merged
merged 2 commits into from
May 15, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented May 15, 2024

It's not obvious how to use the BundleStateWithReceipts that you got from e.g. the ExExNotification as a state provider for the EVM execution.

This PR implements the BundleStateDataProvider for BundleStateWithReceipts by splitting it into two traits: one for general data access and the other for blockchain tree -specific.

@shekhirin shekhirin added C-enhancement New feature or request A-db Related to the database labels May 15, 2024
@shekhirin shekhirin requested a review from mattsse May 15, 2024 13:46
@shekhirin shekhirin marked this pull request as ready for review May 15, 2024 13:46
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see,

tbh, all of this should be revisited

@shekhirin shekhirin added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit aefcfff May 15, 2024
28 checks passed
@shekhirin shekhirin deleted the alexey/bundle-state-provider-impl branch May 15, 2024 14:31
mw2000 pushed a commit to mw2000/reth that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-db Related to the database C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants