docs(book): start documenting ExExes #8779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-docs
Rjected
reviewed
Jun 12, 2024
onbjerg
reviewed
Jun 13, 2024
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
Co-authored-by: Oliver <onbjerg@users.noreply.github.com>
Co-authored-by: Oliver <onbjerg@users.noreply.github.com>
Co-authored-by: Oliver <onbjerg@users.noreply.github.com>
Co-authored-by: Oliver <onbjerg@users.noreply.github.com>
Co-authored-by: Oliver <onbjerg@users.noreply.github.com>
shekhirin
force-pushed
the
alexey/exex-book
branch
from
c0d9e41 to
5728ad8
Compare
onbjerg
approved these changes
Jun 13, 2024
mattsse
approved these changes
Jun 13, 2024
Comment on lines
+73
to
+83
| fn main() -> eyre::Result<()> { | ||
| reth::cli::Cli::parse_args().run(|builder, _| async move { | ||
| let handle = builder | ||
| .node(EthereumNode::default()) | ||
| .install_exex("my-exex", |ctx| async move { Ok(my_exex(ctx)) }) | ||
| .launch() | ||
| .await?; | ||
|
|
||
| handle.wait_for_node_exit().await | ||
| }) | ||
| } |
There was a problem hiding this comment.
these snippets will be hard to maintain
but should be okay
There was a problem hiding this comment.
unfortunately, there seems to be no way to compile snippets that have any dependencies :/
emhane
pushed a commit
that referenced
this pull request
Jun 13, 2024
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com> Co-authored-by: Oliver <onbjerg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The easiest way to review this is to run
mdbook servelocally on this PR and explore the book in your browser.