Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prometheus graceful shutdown #8784

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 12, 2024

ref #8772

this fixes the panic caused by polling the shutdown future multiple twice.

this server has been refactored so that it processes requests sequentially, which isn't ideal but okay.

this removes the bad select and terminates the loop over incoming sockets and exits the loop on shutdown

@mattsse mattsse requested review from Rjected and onbjerg as code owners June 12, 2024 18:22
@mattsse mattsse added the C-bug An unexpected or incorrect behavior label Jun 12, 2024
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yeah that should fix the double poll

@mattsse mattsse added this pull request to the merge queue Jun 12, 2024
Merged via the queue into main with commit 8398625 Jun 12, 2024
29 checks passed
@mattsse mattsse deleted the matt/hotfix-prometheus-server branch June 12, 2024 18:59
emhane pushed a commit that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants